[PATCH] D49663: [x86/SLH] Teach the x86 speculative load hardening pass to harden against v1.2 BCBS attacks directly.

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.

Couple of small nits, but that's it. Still LGTM.



================
Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:2150-2151
+///
+/// When this happens, the speculative
+/// execution of the call or jump will end up being steered to this attacker
+/// controlled address. While most such loads will be adequately hardened
----------------
Nit: Flow.


================
Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:2187
+
+  // For all of these, the target register is zero.
+  auto &TargetOp = MI.getOperand(0);
----------------
Nit: I know you don't mean it, but it sounds like you're talking about r0 on some architecture :)


Repository:
  rL LLVM

https://reviews.llvm.org/D49663