[PATCH] D49687: llvm-xray: Broken chrome trace event format output

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 16:34:14 PDT 2018


dberris accepted this revision.
dberris added subscribers: kpw, sammccall.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM -- good catch, @chris3k.

@kpw, we probably should have tests to cover some more of these cases, now that @sammccall has landed the JSON parser/writer (and also probably move to using that instead of our own ad hoc implementation here).


Repository:
  rL LLVM

https://reviews.llvm.org/D49687





More information about the llvm-commits mailing list