[PATCH] D49687: llvm-xray: Broken chrome trace event format output

[Krzysztof Grzadziel via Phabricator via llvm-commits]

chris3k created this revision.
chris3k added a reviewer: dberris.
Herald added a subscriber: llvm-commits.

Missing comma separator for EXIT and TAIL_EXIT RecordTypes emit invalid
JSON output for Chrome Trace Event Format.


Repository:
  rL LLVM

https://reviews.llvm.org/D49687

Files:
  tools/llvm-xray/xray-converter.cpp


Index: tools/llvm-xray/xray-converter.cpp
===================================================================
--- tools/llvm-xray/xray-converter.cpp
+++ tools/llvm-xray/xray-converter.cpp
@@ -313,6 +313,9 @@
       // (And/Or in loop termination below)
       StackTrieNode *PreviousCursor = nullptr;
       do {
+        if (PreviousCursor != nullptr) {
+          OS << ",\n";
+        }
         writeTraceViewerRecord(Version, OS, StackCursor->FuncId, R.TId, R.PId,
                                Symbolize, FuncIdHelper, EventTimestampUs,
                                *StackCursor, "E");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49687.156840.patch
Type: text/x-patch
Size: 597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180723/b02d640f/attachment.bin>