[PATCH] D48702: objdump: Better handling of Mach-O universal binaries

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 15:39:57 PDT 2018


kastiglione added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:1961
+void llvm::ParseInputMachO(StringRef Filename) {
+  if (!ValidateArchFlags())
+    return;
----------------
compnerd wrote:
> This leaves the old behavior in place, but I think it would be nicer if the `arch` flag was validated earlier.
Did you have something specific in mind? By the caller, before calling this function? Or something elseā€¦


Repository:
  rL LLVM

https://reviews.llvm.org/D48702





More information about the llvm-commits mailing list