[PATCH] D48702: objdump: Better handling of Mach-O universal binaries

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 09:44:22 PDT 2018


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-objdump/MachODump.cpp:1961
+void llvm::ParseInputMachO(StringRef Filename) {
+  if (!ValidateArchFlags())
+    return;
----------------
This leaves the old behavior in place, but I think it would be nicer if the `arch` flag was validated earlier.


Repository:
  rL LLVM

https://reviews.llvm.org/D48702





More information about the llvm-commits mailing list