[PATCH] D44357: [COFF] Adjust how we flag weak externals

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lib/Object/COFFObjectFile.cpp:235
 
-  if (Symb.isAnyUndefined())
-    Result |= SymbolRef::SF_Undefined;
+  if (Symb.isAnyUndefined()) {
+    const coff_aux_weak_external *awe = Symb.getWeakExternal();
----------------
pcc wrote:
> I'd replace this with `isUndefined` and move the logic for whether to give a weak external the undefined bit to the `isWeakExternal` block.
Right, that makes it much cleaner, thanks!


https://reviews.llvm.org/D44357