[PATCH] D44357: [COFF] Adjust how we flag weak externals
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 20 13:04:59 PDT 2018
pcc added inline comments.
================
Comment at: lib/Object/COFFObjectFile.cpp:235
- if (Symb.isAnyUndefined())
- Result |= SymbolRef::SF_Undefined;
+ if (Symb.isAnyUndefined()) {
+ const coff_aux_weak_external *awe = Symb.getWeakExternal();
----------------
I'd replace this with `isUndefined` and move the logic for whether to give a weak external the undefined bit to the `isWeakExternal` block.
https://reviews.llvm.org/D44357
More information about the llvm-commits
mailing list