[PATCH] D49310: [llvm-mca][BtVer2] Teach how to identify dependency-breaking idioms.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: test/tools/llvm-mca/X86/BtVer2/one-idioms.s:28
 
 # FIXME: their handling is broken in llvm-mca.
 
----------------
lebedev.ri wrote:
> You probably wanted to drop this comment.
I will remove it.


================
Comment at: tools/llvm-mca/DispatchStage.cpp:110
   // An example of dependency-breaking instruction on X86 is a zero-idiom XOR.
-  if (!Desc.isZeroLatency())
-    for (std::unique_ptr<ReadState> &RS : IS.getUses())
----------------
lebedev.ri wrote:
> So it will no longer even consider the sched profile?
Not sure I understand the question. I am definitely using profile information from the scheduling model.


https://reviews.llvm.org/D49310