[PATCH] D49473: [MSan] pull insertShadowCheck() into getShadowOriginPtr(). NFC

[Alexander Potapenko via llvm-commits]

Yes, looks like this chunk is enough.
I'll finish comparing the results and update the patch tomorrow.

On Thu, Jul 19, 2018, 22:24 Evgenii Stepanov via Phabricator <
reviews at reviews.llvm.org> wrote:

> eugenis added inline comments.
>
>
> ================
> Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1495
>      StoreList.push_back(&I);
> +    if (ClCheckAccessAddress)
> +      insertShadowCheck(I.getPointerOperand(), &I);
> ----------------
> So all you really need is this chunk, and reordering of materializeStores
> and materializeChecks? Could you revert the rest of the change then?
>
> I prefer the current, more explicit, way of inserting address checks.
>
>
> https://reviews.llvm.org/D49473
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180719/33bce083/attachment.html>