<div dir="auto">Yes, looks like this chunk is enough.<div dir="auto">I'll finish comparing the results and update the patch tomorrow.</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 19, 2018, 22:24 Evgenii Stepanov via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">eugenis added inline comments.<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1495<br>
     StoreList.push_back(&I);<br>
+    if (ClCheckAccessAddress)<br>
+      insertShadowCheck(I.getPointerOperand(), &I);<br>
----------------<br>
So all you really need is this chunk, and reordering of materializeStores and materializeChecks? Could you revert the rest of the change then?<br>
<br>
I prefer the current, more explicit, way of inserting address checks.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D49473" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D49473</a><br>
<br>
<br>
<br>
</blockquote></div>