[PATCH] D49436: [X86][BtVer2] correctly model the latency/throughput of LEA instructions.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 04:12:57 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86FixupLEAs.cpp:289
 /// where the base is EBP, RBP, or R13
 static inline bool hasInefficientLEABaseReg(const MachineOperand &Base,
                                             const MachineOperand &Index) {
----------------
Add a TODO explaining that this should move to the scheduler model variants at some point?


================
Comment at: lib/Target/X86/X86SchedPredicates.td:16
+
+def ZeroIdiomPredicate : CheckSameRegOperand<1, 2>;
+
----------------
Add description comments to each predicate.


https://reviews.llvm.org/D49436





More information about the llvm-commits mailing list