[PATCH] D47681: [DAGCombiner] Bug 31275- Extract a shift from a constant mul or udiv if a rotate can be formed

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 23:15:39 PDT 2018


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D47681#1167516, @sameconrad wrote:

> In https://reviews.llvm.org/D47681#1162716, @lebedev.ri wrote:
>
> > It seems everyone else is busy with other differentials, and don't have time to spare to review this :/
> >
> > Have you run this on a llvm test suite?
> >
> > I don't have further comments, and i could accept this, **if** testsuite passes,
> >  but it would be more comfortable if someone else could review this, too.
>
>
> Sorry about the late response, missed this comment before.  I just ran the test-suite and it looks like all 2555 passed without issue.


Ok then, LG.
Please wait a bit (until monday?) just in case others may want to comment, and then feel free to commit.


https://reviews.llvm.org/D47681





More information about the llvm-commits mailing list