[PATCH] D47681: [DAGCombiner] Bug 31275- Extract a shift from a constant mul or udiv if a rotate can be formed

Sam Conrad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 18:16:03 PDT 2018


sameconrad marked 2 inline comments as done.
sameconrad added a comment.

In https://reviews.llvm.org/D47681#1162716, @lebedev.ri wrote:

> It seems everyone else is busy with other differentials, and don't have time to spare to review this :/
>
> Have you run this on a llvm test suite?
>
> I don't have further comments, and i could accept this, **if** testsuite passes,
>  but it would be more comfortable if someone else could review this, too.


Sorry about the late response, missed this comment before.  I just ran the test-suite and it looks like all 2555 passed without issue.


https://reviews.llvm.org/D47681





More information about the llvm-commits mailing list