[PATCH] D49436: [X86][BtVer2] correctly model the latency/throughput of LEA instructions.
Matt Davis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 17 17:38:22 PDT 2018
mattd added a comment.
I think it makes sense to have a separate patch for checkInvalidRegOperand. I do like that idea in particular, it simplifies reading the tablegen sources.
================
Comment at: utils/TableGen/PredicateExpander.cpp:50
+ OS << "MI" << (isByRef() ? "." : "->") << "getOperand(" << OpIndex
+ << ").getReg() " << (shouldNegate() ? "!= " : "== ") << "0";
+}
----------------
I'm curious about the hardcoded value "0", is the invalid register always 0 for all targets?
https://reviews.llvm.org/D49436
More information about the llvm-commits
mailing list