[PATCH] D49399: Move some utility classes to header files

[David Blaikie via llvm-commits]

Ah, yeah, fair point that they're still implementation details/can't be
included from tests - fine fine (:

On Mon, Jul 16, 2018 at 2:18 PM Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added a comment.
>
> In https://reviews.llvm.org/D49399#1164231, @dblaikie wrote:
>
> > Might be worth some unit tests now that these are reusable components.
>
>
> They're not suuuper re-usable.  They're still considered private
> implementation details (i.e. they're in the source directory, not the
> include directory).  a unittest wouldn't be able to #include the header
> file.  If you think it's worth doing so, I can make them public, but I
> don't think we want anyone outside of LLVMDemangle including these, so it's
> iffy.  I'll submit this for now, if you think I should move the files to
> the include directory and add unit tests, we can do that in a followup.
>
>
> https://reviews.llvm.org/D49399
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180716/7a7dce57/attachment.html>