[PATCH] D49399: Move some utility classes to header files

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D49399#1164231, @dblaikie wrote:

> Might be worth some unit tests now that these are reusable components.


They're not suuuper re-usable.  They're still considered private implementation details (i.e. they're in the source directory, not the include directory).  a unittest wouldn't be able to #include the header file.  If you think it's worth doing so, I can make them public, but I don't think we want anyone outside of LLVMDemangle including these, so it's iffy.  I'll submit this for now, if you think I should move the files to the include directory and add unit tests, we can do that in a followup.


https://reviews.llvm.org/D49399