[PATCH] D49325: [CMake] Change the flag to use compiler-rt builtins to boolean

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/CMakeLists.txt:164
+  set(SANITIZER_DEFAULT_COMPILER_RT OFF)
 endif()
 
----------------
Maybe this would be simpler:

```
set(SANITIZER_DEFAULT_COMPILER_RT OFF)
if (FUCHSIA)
  set(SANITIZER_DEFAULT_COMPILER_RT ON)
endif()
```


================
Comment at: compiler-rt/CMakeLists.txt:166
 
+option(SANITIZER_USE_COMPILER_RT "Use compiler-rt instead of libgcc" ${SANITIZER_DEFAULT_COMPILER_RT})
+
----------------
phosek wrote:
> I'm not a big fan of the name, but another alternative would be `COMPILER_RT_USE_COMPILER_RT` which isn't great either.
`COMPILER_RT_USE_BUILTIN_RUNTIME_LIBRARY`?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49325