[PATCH] D49325: [CMake] Change the flag to use compiler-rt builtins to boolean

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:160
 
-set(COMPILER_RT_RUNTIME "default" CACHE STRING
-    "Compiler runtime to use.")
-
-if (COMPILER_RT_RUNTIME STREQUAL "default")
-  if (FUCHSIA)
-    set(COMPILER_RT_RUNTIME_LIBRARY "builtins")
-  endif()
+if (FUCHSIA)
+  set(SANITIZER_DEFAULT_COMPILER_RT ON)
----------------
@beanz do you know if we could also default to `ON` on `APPLE`?


================
Comment at: compiler-rt/CMakeLists.txt:166
 
+option(SANITIZER_USE_COMPILER_RT "Use compiler-rt instead of libgcc" ${SANITIZER_DEFAULT_COMPILER_RT})
+
----------------
I'm not a big fan of the name, but another alternative would be `COMPILER_RT_USE_COMPILER_RT` which isn't great either.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49325