[PATCH] D49169: Use debug-prefix-map for AT_NAME

[Siddhartha Bagaria via Phabricator via llvm-commits]

starsid marked 2 inline comments as done.
starsid added a comment.

I actually do not have permissions to commit the revision. So if you don't want me to make more changes, can you please commit this.

Please let me know if you want me to follow up on the suggested changes in the inline comments.



================
Comment at: lib/MC/MCContext.cpp:545
+  const auto &DebugPrefixMap = this->DebugPrefixMap;
+  const auto RemapDebugPath = [&DebugPrefixMap](std::string *Path) {
+    for (const auto &Entry : DebugPrefixMap)
----------------
JDevlieghere wrote:
> JDevlieghere wrote:
> > I might have missed something, but can't this be a std::string&?
> I probably would've made this a static non-member function, but I don't think there's anything wrong with a lambda. 
Ack.

Let me know if you actually do want me to convert this to a static non-member function.


================
Comment at: lib/MC/MCContext.cpp:545
+  const auto &DebugPrefixMap = this->DebugPrefixMap;
+  const auto RemapDebugPath = [&DebugPrefixMap](std::string *Path) {
+    for (const auto &Entry : DebugPrefixMap)
----------------
starsid wrote:
> JDevlieghere wrote:
> > JDevlieghere wrote:
> > > I might have missed something, but can't this be a std::string&?
> > I probably would've made this a static non-member function, but I don't think there's anything wrong with a lambda. 
> Ack.
> 
> Let me know if you actually do want me to convert this to a static non-member function.
It can be std::string&, but I thought when your intention is to modify the argument, you take it as a pointer. Sorry, this is my first change following LLVM code style so I am not familiar with what is expected.


Repository:
  rL LLVM

https://reviews.llvm.org/D49169