[PATCH] D49169: Use debug-prefix-map for AT_NAME

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with inline comments.



================
Comment at: lib/MC/MCContext.cpp:545
+  const auto &DebugPrefixMap = this->DebugPrefixMap;
+  const auto RemapDebugPath = [&DebugPrefixMap](std::string *Path) {
+    for (const auto &Entry : DebugPrefixMap)
----------------
I might have missed something, but can't this be a std::string&?


================
Comment at: lib/MC/MCContext.cpp:545
+  const auto &DebugPrefixMap = this->DebugPrefixMap;
+  const auto RemapDebugPath = [&DebugPrefixMap](std::string *Path) {
+    for (const auto &Entry : DebugPrefixMap)
----------------
JDevlieghere wrote:
> I might have missed something, but can't this be a std::string&?
I probably would've made this a static non-member function, but I don't think there's anything wrong with a lambda. 


Repository:
  rL LLVM

https://reviews.llvm.org/D49169