[PATCH] D49056: [Dominators] Add isUpdateLazy() method to the DomTreeUpdater

Chijun Sima via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 10 05:26:19 PDT 2018


NutshellySima added a comment.

In https://reviews.llvm.org/D49056#1156730, @brzycki wrote:

> In https://reviews.llvm.org/D49056#1155925, @kuhar wrote:
>
> > Perhaps it would make sense to expose a similar function for the Eager strategy?
> >  And I would make it sorter, so just `isLazy` and `isEager` -- shouldn't make anything more ambiguous IMO.
>
>
> +1 to both. Having both options makes it easier to read the if checks in my opinion. Otherwise LGTM.


+1. B.T.W, I removed the `getUpdateStrategy` function because `isLazy` and `isEager` can replace its usage.


Repository:
  rL LLVM

https://reviews.llvm.org/D49056





More information about the llvm-commits mailing list