[PATCH] D49056: [Dominators] Add isUpdateLazy() method to the DomTreeUpdater

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 17:22:09 PDT 2018


brzycki added a comment.

In https://reviews.llvm.org/D49056#1155925, @kuhar wrote:

> Perhaps it would make sense to expose a similar function for the Eager strategy?
>  And I would make it sorter, so just `isLazy` and `isEager` -- shouldn't make anything more ambiguous IMO.


+1 to both. Having both options makes it easier to read the if checks in my opinion. Otherwise LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D49056





More information about the llvm-commits mailing list