[PATCH] D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero
Aleksandr Urakov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 10 00:45:37 PDT 2018
aleksandr.urakov requested changes to this revision.
aleksandr.urakov added a comment.
This revision now requires changes to proceed.
Looks good to me, except formatting.
================
Comment at: source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp:74-81
+ LLDB_LOG(log, "This is a Wow64 process, we should create a RegisterContextWindows_Wow64, but we don't.");
#else
- m_reg_context_sp.reset(new RegisterContextWindows_x86(*this, idx));
+ m_thread_reg_ctx_sp.reset(new RegisterContextWindows_x86(*this, concrete_frame_idx));
#endif
- break;
- case llvm::Triple::x86_64:
+ break;
+ case llvm::Triple::x86_64:
#if defined(_WIN64)
----------------
It seems that lines are too long, you can easily reformat this with clang-format.
Repository:
rL LLVM
https://reviews.llvm.org/D49111
More information about the llvm-commits
mailing list