[PATCH] D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, zturner, aleksandr.urakov.
Herald added a subscriber: llvm-commits.

This is a clean version of the change suggested here: https://bugs.llvm.org/show_bug.cgi?id=37495

The main change is to follow the same pattern as non-windows targets and use an unwinder object to retrieve the register context. I also changed a couple of the comments to actually log, so that issues with unsupported scenarios can be tracked down more easily. Lastly, ClearStackFrames is implemented in the base class, so individual thread implementations don't have to override it.


Repository:
  rL LLVM

https://reviews.llvm.org/D49111

Files:
  source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
  source/Plugins/Process/Windows/Common/TargetThreadWindows.h
  source/Plugins/Process/elf-core/ThreadElfCore.cpp
  source/Plugins/Process/elf-core/ThreadElfCore.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49111.154739.patch
Type: text/x-patch
Size: 5076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180710/fa56212b/attachment.bin>