[PATCH] D48836: [cfi-verify] Support AArch64.

[Joel Galenson via Phabricator via llvm-commits]

jgalenson added a comment.

Thanks.  I'll wait a bit to see if there are any more comments.



================
Comment at: tools/llvm-cfi-verify/lib/FileAnalysis.h:152
   // Returns the first place the operand register is clobbered between the CFI-
-  // check and the indirect CF instruction execution. If the register is not
-  // modified, returns the address of the indirect CF instruction. The result is
-  // undefined if the provided graph does not fall under either the
-  // FAIL_REGISTER_CLOBBERED or PROTECTED status (see CFIProtectionStatus).
+  // check and the indirect CF instruction execution. We do this by walking
+  // backwards from the indirect CF and ensuring there is at most one load
----------------
vlad.tsyrklevich wrote:
> This is true for AArch64 but not x86.
The way I meant it, this actually included x86 since there the load happens on the indirect branch itself.  I can change this to make that more clear, though.


https://reviews.llvm.org/D48836