[PATCH] D48836: [cfi-verify] Support AArch64.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich accepted this revision.
vlad.tsyrklevich added a comment.
This revision is now accepted and ready to land.

Changes seem reasonable to me modulo the one nit, though I'd give @pcc a chance to look at it as well if he has any feedback.



================
Comment at: tools/llvm-cfi-verify/lib/FileAnalysis.h:152
   // Returns the first place the operand register is clobbered between the CFI-
-  // check and the indirect CF instruction execution. If the register is not
-  // modified, returns the address of the indirect CF instruction. The result is
-  // undefined if the provided graph does not fall under either the
-  // FAIL_REGISTER_CLOBBERED or PROTECTED status (see CFIProtectionStatus).
+  // check and the indirect CF instruction execution. We do this by walking
+  // backwards from the indirect CF and ensuring there is at most one load
----------------
This is true for AArch64 but not x86.


https://reviews.llvm.org/D48836