[PATCH] D48985: [WebAssembly] Converted to stack based instructions in MC.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added a comment.

This is WiP because there's a lot of work still to do to make the tests pass, and I wanted to gather input on whether I am doing the right thing.
It may take weeks for me to land this.

If you're doing work that conflicts with this, you're likely best of targeting the old format, and then I will resolve/convert it. Unless of course you think it will take you even longer than me :)



================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:201
+                       InstName.startswith("atomic_load") ||
+                       InstName.startswith("atomic_store");
+    if (IsLoadStore) {
----------------
aheejin wrote:
> Can we infer this information from `Operands`? Looks like `OperandVector` is a vector of `unique_ptr` of ` MCParsedAsmOperand`, which has `isMem()` member function.
> Otherwise after we add other atomic read-modify-write instructions we are gonna need them here as well.
I don't have Operands here, only tokens. The Operands/MCInst are generated by the asm matcher, which comes after this.


Repository:
  rL LLVM

https://reviews.llvm.org/D48985