[PATCH] D48985: [WebAssembly] Converted to stack based instructions in MC.

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Why is this WIP and when do you plan to land this? I'm working on tests that may conflict with this, so I'm not sure which format I should target.



================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:201
+                       InstName.startswith("atomic_load") ||
+                       InstName.startswith("atomic_store");
+    if (IsLoadStore) {
----------------
Can we infer this information from `Operands`? Looks like `OperandVector` is a vector of `unique_ptr` of ` MCParsedAsmOperand`, which has `isMem()` member function.
Otherwise after we add other atomic read-modify-write instructions we are gonna need them here as well.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h:130
   case WebAssembly::ATOMIC_STORE8_I64:
+  case WebAssembly::ATOMIC_STORE8_I64_S:
     return 0;
----------------
I added these in D48992 before seeing this. Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D48985