[llvm] r336402 - Revert "objdump: Support newer ObjC image info flags"

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 22:20:46 PDT 2018


You can follow the steps in http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn to get an SVN revision number instead of a git commit hash in your revert message, and it's also a good idea to note why you're performing the revert.

From: llvm-commits <llvm-commits-bounces at lists.llvm.org> on behalf of Dave Lee via llvm-commits <llvm-commits at lists.llvm.org>
Reply-To: Dave Lee <davelee.com at gmail.com>
Date: Thursday, July 5, 2018 at 5:18 PM
To: "llvm-commits at lists.llvm.org" <llvm-commits at lists.llvm.org>
Subject: [llvm] r336402 - Revert "objdump: Support newer ObjC image info flags"

Author: kastiglione
Date: Thu Jul  5 17:13:21 2018
New Revision: 336402

URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D336402-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=B92YLfxfIIS06k5MbquaDNIgzME4_DdKZbSDed9cWm0&e=
Log:
Revert "objdump: Support newer ObjC image info flags"

This reverts commit 8c4cc472e7a67bd3b2b20cc4cf32d31af29bc7e9.

Removed:
    llvm/trunk/test/tools/llvm-objdump/macho-image-info.test
Modified:
    llvm/trunk/tools/llvm-objdump/MachODump.cpp

Removed: llvm/trunk/test/tools/llvm-objdump/macho-image-info.test
URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_tools_llvm-2Dobjdump_macho-2Dimage-2Dinfo.test-3Frev-3D336401-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=E_rslrDRi3H1N6UbKbvyskxytuzDQ8YHtxwzW5UKmwk&e=
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/macho-image-info.test (original)
+++ llvm/trunk/test/tools/llvm-objdump/macho-image-info.test (removed)
@@ -1,7 +0,0 @@
-# RUN: llvm-mc < %s -triple x86_64-darwin -filetype=obj | llvm-objdump -m -objc-meta-data - | FileCheck %s
-
-.section              __DATA,__objc_imageinfo,regular,no_dead_strip
-.long    0
-.long    96
-
-# CHECK: OBJC_IMAGE_IS_SIMULATED OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES

Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_tools_llvm-2Dobjdump_MachODump.cpp-3Frev-3D336402-26r1-3D336401-26r2-3D336402-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=mCdpfdd0JpElZ92IG-RjfRv4meSQgWQvE7qztKTi8xI&e=
==============================================================================
--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Thu Jul  5 17:13:21 2018
@@ -3229,8 +3229,6 @@ struct imageInfo_t {
/* masks for objc_image_info.flags */
#define OBJC_IMAGE_IS_REPLACEMENT (1 << 0)
#define OBJC_IMAGE_SUPPORTS_GC (1 << 1)
-#define OBJC_IMAGE_IS_SIMULATED (1 << 5)
-#define OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES (1 << 6)
struct message_ref64 {
   uint64_t imp; /* IMP (64-bit pointer) */
@@ -5592,10 +5590,6 @@ static void print_image_info64(SectionRe
     outs() << " OBJC_IMAGE_IS_REPLACEMENT";
   if (o.flags & OBJC_IMAGE_SUPPORTS_GC)
     outs() << " OBJC_IMAGE_SUPPORTS_GC";
-  if (o.flags & OBJC_IMAGE_IS_SIMULATED)
-    outs() << " OBJC_IMAGE_IS_SIMULATED";
-  if (o.flags & OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES)
-    outs() << " OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES";
   swift_version = (o.flags >> 8) & 0xff;
   if (swift_version != 0) {
     if (swift_version == 1)


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=2gaLgwx8a8Mkz3mzSWiocs5uHVzRyCaKqCulAbzX4mE&e=

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180706/a3c2150e/attachment.html>


More information about the llvm-commits mailing list