<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.apple-tab-span
{mso-style-name:apple-tab-span;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">You can follow the steps in <a href="http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn">
http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn</a> to get an SVN revision number instead of a git commit hash in your revert message, and it's also a good idea to note why you're performing the revert.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">llvm-commits <llvm-commits-bounces@lists.llvm.org> on behalf of Dave Lee via llvm-commits <llvm-commits@lists.llvm.org><br>
<b>Reply-To: </b>Dave Lee <davelee.com@gmail.com><br>
<b>Date: </b>Thursday, July 5, 2018 at 5:18 PM<br>
<b>To: </b>"llvm-commits@lists.llvm.org" <llvm-commits@lists.llvm.org><br>
<b>Subject: </b>[llvm] r336402 - Revert "objdump: Support newer ObjC image info flags"<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Author: kastiglione<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Date: Thu Jul 5 17:13:21 2018<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">New Revision: 336402<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D336402-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=B92YLfxfIIS06k5MbquaDNIgzME4_DdKZbSDed9cWm0&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D336402-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=B92YLfxfIIS06k5MbquaDNIgzME4_DdKZbSDed9cWm0&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Log:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Revert "objdump: Support newer ObjC image info flags"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">This reverts commit 8c4cc472e7a67bd3b2b20cc4cf32d31af29bc7e9.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Removed:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> llvm/trunk/test/tools/llvm-objdump/macho-image-info.test<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> llvm/trunk/tools/llvm-objdump/MachODump.cpp<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Removed: llvm/trunk/test/tools/llvm-objdump/macho-image-info.test<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_tools_llvm-2Dobjdump_macho-2Dimage-2Dinfo.test-3Frev-3D336401-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=E_rslrDRi3H1N6UbKbvyskxytuzDQ8YHtxwzW5UKmwk&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_tools_llvm-2Dobjdump_macho-2Dimage-2Dinfo.test-3Frev-3D336401-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=E_rslrDRi3H1N6UbKbvyskxytuzDQ8YHtxwzW5UKmwk&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">==============================================================================<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">--- llvm/trunk/test/tools/llvm-objdump/macho-image-info.test (original)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+++ llvm/trunk/test/tools/llvm-objdump/macho-image-info.test (removed)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">@@ -1,7 +0,0 @@<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-# RUN: llvm-mc < %s -triple x86_64-darwin -filetype=obj | llvm-objdump -m -objc-meta-data - | FileCheck %s<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-.section<span class="apple-tab-span">
</span>__DATA,__objc_imageinfo,regular,no_dead_strip<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-.long<span class="apple-tab-span">
</span>0<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-.long<span class="apple-tab-span">
</span>96<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-# CHECK: OBJC_IMAGE_IS_SIMULATED OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_tools_llvm-2Dobjdump_MachODump.cpp-3Frev-3D336402-26r1-3D336401-26r2-3D336402-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=mCdpfdd0JpElZ92IG-RjfRv4meSQgWQvE7qztKTi8xI&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_tools_llvm-2Dobjdump_MachODump.cpp-3Frev-3D336402-26r1-3D336401-26r2-3D336402-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=mCdpfdd0JpElZ92IG-RjfRv4meSQgWQvE7qztKTi8xI&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">==============================================================================<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Thu Jul 5 17:13:21 2018<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">@@ -3229,8 +3229,6 @@ struct imageInfo_t {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">/* masks for objc_image_info.flags */<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">#define OBJC_IMAGE_IS_REPLACEMENT (1 << 0)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">#define OBJC_IMAGE_SUPPORTS_GC (1 << 1)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-#define OBJC_IMAGE_IS_SIMULATED (1 << 5)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-#define OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES (1 << 6)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">struct message_ref64 {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> uint64_t imp; /* IMP (64-bit pointer) */<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">@@ -5592,10 +5590,6 @@ static void print_image_info64(SectionRe<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> outs() << " OBJC_IMAGE_IS_REPLACEMENT";<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> if (o.flags & OBJC_IMAGE_SUPPORTS_GC)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> outs() << " OBJC_IMAGE_SUPPORTS_GC";<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- if (o.flags & OBJC_IMAGE_IS_SIMULATED)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- outs() << " OBJC_IMAGE_IS_SIMULATED";<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- if (o.flags & OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- outs() << " OBJC_IMAGE_HAS_CATEGORY_CLASS_PROPERTIES";<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> swift_version = (o.flags >> 8) & 0xff;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> if (swift_version != 0) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> if (swift_version == 1)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">_______________________________________________<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">llvm-commits mailing list<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=2gaLgwx8a8Mkz3mzSWiocs5uHVzRyCaKqCulAbzX4mE&e=">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=R0uTmOP5cZGFOdgqZDJwmumW0zjdjvn99nKlhxOSotU&s=2gaLgwx8a8Mkz3mzSWiocs5uHVzRyCaKqCulAbzX4mE&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
</div>
</body>
</html>