[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY
Louis Dionne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 3 12:52:36 PDT 2018
ldionne added inline comments.
================
Comment at: libcxx/include/any:107-115
+_LIBCPP_NORETURN inline _LIBCPP_INLINE_VISIBILITY
void __throw_bad_any_cast()
{
#ifndef _LIBCPP_NO_EXCEPTIONS
throw bad_any_cast();
#else
_VSTD::abort();
----------------
dexonsmith wrote:
> It's possible that this (and other `__throw_*` functions) were trying to force inlining (i.e., not just controlling visibility). However, if so, I disagree with it; I'd rather trust the optimizer to do the right thing.
What would be the reason for wanting to always inline that?
Repository:
rL LLVM
https://reviews.llvm.org/D48892
More information about the llvm-commits
mailing list