[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a reviewer: mclow.lists.
dexonsmith added a comment.

FWIW, this change LGTM... but I wouldn't mind hearing from Eric or Marshall before commit.



================
Comment at: libcxx/include/any:107-115
+_LIBCPP_NORETURN inline _LIBCPP_INLINE_VISIBILITY
 void __throw_bad_any_cast()
 {
 #ifndef _LIBCPP_NO_EXCEPTIONS
     throw bad_any_cast();
 #else
 	_VSTD::abort();
----------------
It's possible that this (and other `__throw_*` functions) were trying to force inlining (i.e., not just controlling visibility).  However, if so, I disagree with it; I'd rather trust the optimizer to do the right thing.


Repository:
  rL LLVM

https://reviews.llvm.org/D48892