[PATCH] D48811: Fix disassembling ARM instructions as big-endian
Javed Absar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 2 02:02:06 PDT 2018
javed.absar added a comment.
Is this applicable only for ARMv6 case? From the patch it does not seem so and so may be good to add cases for ARMv7 as well.
================
Comment at: test/MC/Disassembler/ARM/endian.txt:1
+# RUN: echo "0x01 0x00 0xa0 0xe1" | llvm-mc -triple=armv6-none -disassemble | FileCheck %s -check-prefix=ARM
+# RUN: echo "0xe1 0xa0 0x00 0x01" | llvm-mc -triple=armv6eb-none -disassemble | FileCheck %s -check-prefix=ARM
----------------
Please consider adding a line description of the test. Kind of obvious from reading the test but may still be useful.
Repository:
rL LLVM
https://reviews.llvm.org/D48811
More information about the llvm-commits
mailing list