[PATCH] D48770: [dsymutil] Make the CachedBinaryHolder the default.
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 29 09:13:45 PDT 2018
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: llvm/tools/dsymutil/BinaryHolder.h:100
struct KeyTy {
- StringRef Filename;
+ std::string Filename;
TimestampTy Timestamp;
----------------
friss wrote:
> Why does this have to change in this patch? This looks like it's addressing a lifetime issue, but I'm not sure which one (and wouldn't it be needed in D48501?)
Correct. I'll move into the first patch.
Repository:
rL LLVM
https://reviews.llvm.org/D48770
More information about the llvm-commits
mailing list