[PATCH] D48770: [dsymutil] Make the CachedBinaryHolder the default.

[Frederic Riss via Phabricator via llvm-commits]

friss added inline comments.


================
Comment at: llvm/tools/dsymutil/BinaryHolder.h:100
     struct KeyTy {
-      StringRef Filename;
+      std::string Filename;
       TimestampTy Timestamp;
----------------
Why does this have to change in this patch? This looks like it's addressing a lifetime issue, but I'm not sure which one (and wouldn't it be needed in D48501?)


Repository:
  rL LLVM

https://reviews.llvm.org/D48770