[lld] r335848 - Fix warning on MSVC by using size_t arithmetic instead of casting after the fact. NFC

[Rui Ueyama via llvm-commits]

Doesn't `size_t SymIndex = (size_t)-1` work? The expression `size_t{0} - 1`
is somewhat unfamiliar and looks a bit odd to me.

On Thu, Jun 28, 2018 at 9:43 PM Filipe Cabecinhas via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: filcab
> Date: Thu Jun 28 05:38:43 2018
> New Revision: 335848
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335848&view=rev
> Log:
> Fix warning on MSVC by using size_t arithmetic instead of casting after
> the fact. NFC
>
> Modified:
>     lld/trunk/COFF/SymbolTable.cpp
>
> Modified: lld/trunk/COFF/SymbolTable.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=335848&r1=335847&r2=335848&view=diff
>
> ==============================================================================
> --- lld/trunk/COFF/SymbolTable.cpp (original)
> +++ lld/trunk/COFF/SymbolTable.cpp Thu Jun 28 05:38:43 2018
> @@ -189,7 +189,7 @@ void SymbolTable::reportRemainingUndefin
>    }
>
>    for (ObjFile *File : ObjFile::Instances) {
> -    size_t SymIndex = -1ull;
> +    size_t SymIndex = size_t{0} - 1;
>      for (Symbol *Sym : File->getSymbols()) {
>        ++SymIndex;
>        if (!Sym)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180629/1efc1692/attachment.html>