<div dir="ltr">Doesn't `size_t <span style="text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">SymIndex = (size_t)-1` work? The expression `size_t{0} - 1` is somewhat unfamiliar and looks a bit odd to me.</span><br style="text-decoration-style:initial;text-decoration-color:initial"></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 28, 2018 at 9:43 PM Filipe Cabecinhas via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: filcab<br>
Date: Thu Jun 28 05:38:43 2018<br>
New Revision: 335848<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=335848&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=335848&view=rev</a><br>
Log:<br>
Fix warning on MSVC by using size_t arithmetic instead of casting after the fact. NFC<br>
<br>
Modified:<br>
    lld/trunk/COFF/SymbolTable.cpp<br>
<br>
Modified: lld/trunk/COFF/SymbolTable.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=335848&r1=335847&r2=335848&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/SymbolTable.cpp?rev=335848&r1=335847&r2=335848&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/COFF/SymbolTable.cpp (original)<br>
+++ lld/trunk/COFF/SymbolTable.cpp Thu Jun 28 05:38:43 2018<br>
@@ -189,7 +189,7 @@ void SymbolTable::reportRemainingUndefin<br>
   }<br>
<br>
   for (ObjFile *File : ObjFile::Instances) {<br>
-    size_t SymIndex = -1ull;<br>
+    size_t SymIndex = size_t{0} - 1;<br>
     for (Symbol *Sym : File->getSymbols()) {<br>
       ++SymIndex;<br>
       if (!Sym)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>