[PATCH] D48383: [Dominators] Add the DomTreeUpdater class
Brian Rzycki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 27 16:21:00 PDT 2018
brzycki added a comment.
> If we agree that it would be better to have well-behaved updates in most of the places in the future, then having distinct names for these two should make it much easier to grep for. Additionally, it seems like it's not always possible to perform them with the eager strategy, is it?
Good point, I didn't think of the calls being easier to grep. Sounds good to me. And yes, I would prefer all updates to be strict and done after CFG updates, but reality isn't always so forgiving. Having explicit `*Relaxed()` calls can make them easier to identify and potentially fix as we go.
https://reviews.llvm.org/D48383
More information about the llvm-commits
mailing list