[PATCH] D48383: [Dominators] Add the DomTreeUpdater class

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 14:41:08 PDT 2018


kuhar added a comment.

In https://reviews.llvm.org/D48383#1145727, @brzycki wrote:

> > 2. Add insertEdgeRelaxed() and deleteEdgeRelaxed() to cover the behavior of the original DeferredDominance's insertEdge()/deleteEdge().
>
> Maybe it'd be better to have a default boolean third variable?
>  `deleteEdge(BasicBlock *From, BasicBlock *To, bool Relaxed = false) { ...`


If we agree that it would be better to have well-behaved updates in most of the places in the future, then having distinct names for these two should make it much easier to grep for. Additionally, it seems like it's not always possible to perform them with the eager strategy, is it?


https://reviews.llvm.org/D48383





More information about the llvm-commits mailing list