[PATCH] D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling()

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: lib/Target/PowerPC/PPCSubtarget.cpp:169
   // Enable MI scheduling for the embedded cores.
   // FIXME: Enable this for all cores (some additional modeling
   // may be necessary).
----------------
echristo wrote:
> Might want to fix up the comment? :)
I'd probably just delete the comment.


================
Comment at: lib/Target/PowerPC/PPCSubtarget.cpp:189-190
                                        unsigned NumRegionInstrs) const {
-  if (needsAggressiveScheduling(DarwinDirective)) {
-    Policy.OnlyTopDown = false;
-    Policy.OnlyBottomUp = false;
-  }
+  Policy.OnlyTopDown = false;
+  Policy.OnlyBottomUp = false;
 
----------------
echristo wrote:
> These appear to be the defaults?
We should probably comment on why we do this?


================
Comment at: lib/Target/PowerPC/PPCSubtarget.cpp:198
 bool PPCSubtarget::useAA() const {
   // Use AA during code generation for the embedded cores.
+  return true;
----------------
echristo wrote:
> Comment update?
Same.


https://reviews.llvm.org/D48663