[PATCH] D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling()

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 13:34:40 PDT 2018


stefanp updated this revision to Diff 153164.
stefanp added a comment.

Updated the comments. 
Sorry.. I should have caught them initially.

For the defaults:

  Policy.OnlyTopDown = false; 
  Policy.OnlyBottomUp = false;

The flag `Policy.OnlyTopDown` does default to false.
However, `GenericScheduler::initPolicy` changes the default of `Policy.OnlyBottomUp` to true. I've fixed this so that I only use `Policy.OnlyBottomUp = false;` and not the other flag which is already a default.


https://reviews.llvm.org/D48663

Files:
  lib/Target/PowerPC/PPCSubtarget.cpp
  test/CodeGen/PowerPC/2008-10-28-f128-i32.ll
  test/CodeGen/PowerPC/2011-12-05-NoSpillDupCR.ll
  test/CodeGen/PowerPC/coalesce-ext.ll
  test/CodeGen/PowerPC/fp128-bitcast-after-operation.ll
  test/CodeGen/PowerPC/i1-to-double.ll
  test/CodeGen/PowerPC/lsa.ll
  test/CodeGen/PowerPC/ppc32-vacopy.ll
  test/CodeGen/PowerPC/ppc64-gep-opt.ll
  test/CodeGen/PowerPC/save-cr-ppc32svr4.ll
  test/CodeGen/PowerPC/save-crbp-ppc32svr4.ll
  test/CodeGen/PowerPC/tls.ll
  test/CodeGen/PowerPC/unal-altivec.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48663.153164.patch
Type: text/x-patch
Size: 46212 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/213b9c24/attachment-0001.bin>


More information about the llvm-commits mailing list