[PATCH] D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: test/Transforms/InstCombine/debuginfo-trunc-and-zext.ll:1
+; ModuleID = 'debuginfo-trunc-and-zext.ll'
+source_filename = "debuginfo-trunc-and-zext.ll"
----------------
vsk wrote:
> lebedev.ri wrote:
> > This does not actually check anything, there is no `RUN` line.
> Right. When you add a run line, please reduce this test by invoking `opt -debugify`, instead of checking in unnecessary metadata lines.
Is that really a good idea?
1) It is really hard to review this without knowing what the input looks like.
2) As this will be a regression test, isn't it better to have the input fixated. Who know what -debugify will generate for this input in the future.
3) There might be lots of redundant debug info generated by -debugify, making it hard to understand the test case if it fails in the future (specially without knowing if -debugify generated something differently originally).


Repository:
  rL LLVM

https://reviews.llvm.org/D48331