[PATCH] D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: test/Transforms/InstCombine/debuginfo-trunc-and-zext.ll:17
+
+; CHECK: define i32 @test-scalar
+; CHECK: {{.*}} = mul i32 {{.*}}
----------------
Please move the check line closer to the associated IR. You can pick whether to add the checks after the associated IR lines or before. So:
```
; CHECK-LABEL: define i32 @test-scalar
define i32 @test-scalar(i32 %x, i32 %y) {
```
etc.


================
Comment at: test/Transforms/InstCombine/debuginfo-trunc-and-zext.ll:18
+; CHECK: define i32 @test-scalar
+; CHECK: {{.*}} = mul i32 {{.*}}
+; CHECK-NEXT: call void @llvm.dbg.value{{.*}}
----------------
This just tests that there are some dbg.values. Please make the test more specific by checking that the operand of the dbg.value is correct.


Repository:
  rL LLVM

https://reviews.llvm.org/D48331