[PATCH] D48629: Do not sext i1 constants when selecting binary ops

Dragan Mladjenovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 27 04:27:26 PDT 2018


draganm created this revision.
draganm added a reviewer: mcrosier.
Herald added subscribers: arichardson, sdardis.

MipsFastISel comparison lowering relies on i1 values allways being 1 or 0 zero extended which can be broken by [X]OR binop. 
I chose to fix it here because it gives a slightly better codegen on MIPS.


Repository:
  rL LLVM

https://reviews.llvm.org/D48629

Files:
  lib/CodeGen/SelectionDAG/FastISel.cpp
  test/CodeGen/Mips/Fast-ISel/xori1.ll
  test/CodeGen/X86/avx512-fsel.ll
  test/CodeGen/X86/pr32256.ll
  test/CodeGen/X86/pr32284.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48629.153038.patch
Type: text/x-patch
Size: 5450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180627/f4a00ba5/attachment.bin>


More information about the llvm-commits mailing list