[llvm] r335585 - [AArch64] Clean up LSE directive tests

Bernard Ogden via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 26 02:36:13 PDT 2018


Author: bogden
Date: Tue Jun 26 02:36:13 2018
New Revision: 335585

URL: http://llvm.org/viewvc/llvm-project?rev=335585&view=rev
Log:
[AArch64] Clean up LSE directive tests

These were specifying an architecture version with .cpu directive,
which is invalid. As the error for this case outputs the problem
instruction we were still matching the expectations of FileCheck.

This patch fixes up the LSE tests to do what they seem to intend. A
follow-up patch will tighten up the directive tests.

Differential Revision: https://reviews.llvm.org/D47872


Modified:
    llvm/trunk/test/MC/AArch64/directive-arch.s
    llvm/trunk/test/MC/AArch64/directive-cpu.s

Modified: llvm/trunk/test/MC/AArch64/directive-arch.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AArch64/directive-arch.s?rev=335585&r1=335584&r2=335585&view=diff
==============================================================================
--- llvm/trunk/test/MC/AArch64/directive-arch.s (original)
+++ llvm/trunk/test/MC/AArch64/directive-arch.s Tue Jun 26 02:36:13 2018
@@ -8,3 +8,12 @@
 # CHECK: 	aesd	v0.16b, v2.16b
 # CHECK:        eor     v0.16b, v0.16b, v2.16b
 
+// PR32873: without extra features, '.arch' is currently ignored.
+// Add an unrelated feature to accept the directive.
+	.arch armv8.1-a+crypto
+        casa  w5, w7, [x20]
+# CHECK:        casa    w5, w7, [x20]
+
+	.arch armv8-a+lse
+	casa  w5, w7, [x20]
+# CHECK:        casa    w5, w7, [x20]

Modified: llvm/trunk/test/MC/AArch64/directive-cpu.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AArch64/directive-cpu.s?rev=335585&r1=335584&r2=335585&view=diff
==============================================================================
--- llvm/trunk/test/MC/AArch64/directive-cpu.s (original)
+++ llvm/trunk/test/MC/AArch64/directive-cpu.s Tue Jun 26 02:36:13 2018
@@ -36,10 +36,10 @@
 
 	aesd v0.16b, v2.16b
 
-	.cpu generic+v8.1a+nolse
+	.cpu generic+nolse
         casa  w5, w7, [x20]
 
-	.cpu generic+v8.1a+lse
+	.cpu generic+lse
         casa  w5, w7, [x20]
 
 // NOTE: the errors precede the actual output!  The errors appear in order




More information about the llvm-commits mailing list