[PATCH] D47842: [ThinLTO] Add string saver onto index for value names

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D47842#1142784, @pcc wrote:

> What is the goal of making Saver and Alloc optional? Is it to reduce the size of the structure? If that's the case, it doesn't look like it will help, in fact it will increase the size because sizeof(Optional<T>) > sizeof(T).
>  http://llvm-cs.pcc.me.uk/include/llvm/ADT/Optional.h#114


Are you sure that is the case for Alloc? The BumpPtrAllocatorImpl has a number of data members.


Repository:
  rL LLVM

https://reviews.llvm.org/D47842