[PATCH] D47842: [ThinLTO] Add string saver onto index for value names

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 14:00:00 PDT 2018


pcc added a comment.

What is the goal of making Saver and Alloc optional? Is it to reduce the size of the structure? If that's the case, it doesn't look like it will help, in fact it will increase the size because sizeof(Optional<T>) > sizeof(T).
http://llvm-cs.pcc.me.uk/include/llvm/ADT/Optional.h#114


Repository:
  rL LLVM

https://reviews.llvm.org/D47842





More information about the llvm-commits mailing list