[PATCH] D48537: AMDGPU: Add pass to lower kernel arguments to loads

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPULowerKernelArguments.cpp:164
+
+      ArgPtr = Builder.CreateConstGEP1_64(KernArgBase, AlignDownOffset);
+      ArgPtr = Builder.CreateBitCast(ArgPtr,
----------------
I mean to give a name derived from the argument to this gep.


================
Comment at: lib/Target/AMDGPU/AMDGPULowerKernelArguments.cpp:168
+    } else
+      ArgPtr = Builder.CreateStructGEP(CastStruct, Arg.getArgNo());
+
----------------
.. also this GEP.


https://reviews.llvm.org/D48537