[PATCH] D48496: [llvm-mca] Rename Backend to Pipeline. NFC.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 25 09:50:06 PDT 2018


mattd marked 10 inline comments as done.
mattd added a comment.

Thanks for the feedback.  I'll make the changes and land the patch.



================
Comment at: tools/llvm-mca/Pipeline.h:11
 ///
-/// This file implements an OoO backend for the llvm-mca tool.
+/// This file implements an OoO pipeline for the llvm-mca tool.
 ///
----------------
courbet wrote:
> andreadb wrote:
> > courbet wrote:
> > > andreadb wrote:
> > > > Remove the OoO part. I don't think it makes much sense when applied to pipeline.
> > > I would keep it, just to make it clear to the reader that  it's not strictly a linear DAG.
> > The Pipeline (as a container of stages) is not out-of-order. Instead, the hardware backend is OoO. I don't think it is semantically correct to say that the Pipeline is out-of-order.
> > We could rephrase this as "a Stage pipeline for an OoO processor". Or something similar.
> SG
That's a very interesting distinction I never really considered, but do agree with. It sounds like we should probably define the terms (backend,pipeline,component) formally somewhere, perhaps as a separate  commit to the mythical documentation that describes the stage and pipeline designs :) 


https://reviews.llvm.org/D48496





More information about the llvm-commits mailing list