[PATCH] D48496: [llvm-mca] Rename Backend to Pipeline. NFC.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 25 04:28:36 PDT 2018
courbet added inline comments.
================
Comment at: tools/llvm-mca/Pipeline.h:11
///
-/// This file implements an OoO backend for the llvm-mca tool.
+/// This file implements an OoO pipeline for the llvm-mca tool.
///
----------------
andreadb wrote:
> courbet wrote:
> > andreadb wrote:
> > > Remove the OoO part. I don't think it makes much sense when applied to pipeline.
> > I would keep it, just to make it clear to the reader that it's not strictly a linear DAG.
> The Pipeline (as a container of stages) is not out-of-order. Instead, the hardware backend is OoO. I don't think it is semantically correct to say that the Pipeline is out-of-order.
> We could rephrase this as "a Stage pipeline for an OoO processor". Or something similar.
SG
https://reviews.llvm.org/D48496
More information about the llvm-commits
mailing list